You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticed discussion on #18 has stalled, and I'm getting an unspecified warning for object-keys@0.4.0 when installing another package that depends on progress-stream. Thought I would just bump the deps in an isolated PR to move this forward and close#15.
Changing throught2 dependency from v0.2 to v2.0 is a major change: they migrated from Streams2 to Streams3, this may impact progress-stream users. Is this reasonable to push that with only a version bump on patch ?
This could be seen as a new feature: it provides Streams3 behavior, which should globally be backward compatible.
This could also be seen as a breaking change: in some cases Streams3 breaks Streams2 compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed discussion on #18 has stalled, and I'm getting an unspecified warning for
object-keys@0.4.0when installing another package that depends onprogress-stream. Thought I would just bump the deps in an isolated PR to move this forward and close #15.